Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoutePattern.apply(Method, Path) #2503

Merged
merged 1 commit into from
Nov 10, 2023
Merged

RoutePattern.apply(Method, Path) #2503

merged 1 commit into from
Nov 10, 2023

Conversation

nafg
Copy link
Contributor

@nafg nafg commented Oct 31, 2023

If I want to reuse a Path that I also use elsewhere, I shouldn't have to encode it to a String just for the library to decode it back to a Path...

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1ee9701) 64.95% compared to head (8358ac6) 64.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2503      +/-   ##
==========================================
- Coverage   64.95%   64.94%   -0.02%     
==========================================
  Files         136      136              
  Lines        7197     7197              
  Branches     1296     1291       -5     
==========================================
- Hits         4675     4674       -1     
- Misses       2522     2523       +1     
Files Coverage Δ
...io-http/src/main/scala/zio/http/RoutePattern.scala 72.91% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit 93d8229 into zio:main Nov 10, 2023
14 checks passed
@nafg nafg deleted the patch-2 branch April 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants