Added getAs for QueryParams - errors enhancement #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BanyMaciej
requested review from
amitksingh1490,
jdegoes,
vigoo,
adamgfraser and
987Nabil
as code owners
guersam
reviewed
Nov 8, 2023
| } | ||
| def getAllAs[A](key: String)(implicit codec: TextCodec[A]): Either[QueryParamsError, Chunk[A]] = for { | ||
| params <- map.get(key).toRight(QueryParamsError.Missing(key)) | ||
| (failed, typed) = params.map(p => codec.decode(p).toRight(p)).partitionMap(identity) |
There was a problem hiding this comment.
partitionMap(identity) seems redundant.
Suggested change
| (failed, typed) = params.map(p => codec.decode(p).toRight(p)).partitionMap(identity) | |
| (failed, typed) = params.partitionMap(p => codec.decode(p).toRight(p)) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
+ Coverage 64.95% 64.96% +0.01%
==========================================
Files 136 137 +1
Lines 7197 7208 +11
Branches 1296 1288 -8
==========================================
+ Hits 4675 4683 +8
- Misses 2522 2525 +3
☔ View full report in Codecov by Sentry. |
987Nabil
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2505