Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate broken SSL test #2531

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Deactivate broken SSL test #2531

merged 1 commit into from
Nov 24, 2023

Conversation

987Nabil
Copy link
Contributor

No description provided.

@987Nabil 987Nabil force-pushed the fix-ssl-test branch 6 times, most recently from d041f70 to 99886f0 Compare November 23, 2023 17:10
@987Nabil 987Nabil changed the title Change to google.com for example URL with SSL check Deactivate broken SSL test Nov 24, 2023
@987Nabil 987Nabil enabled auto-merge (squash) November 24, 2023 01:32
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (93d8229) 65.02% compared to head (54a389d) 64.94%.
Report is 3 commits behind head on main.

Files Patch % Lines
zio-http/src/main/scala/zio/http/Route.scala 66.66% 4 Missing ⚠️
zio-http/src/main/scala/zio/http/Routes.scala 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
- Coverage   65.02%   64.94%   -0.09%     
==========================================
  Files         137      137              
  Lines        7229     7243      +14     
  Branches     1310     1248      -62     
==========================================
+ Hits         4701     4704       +3     
- Misses       2528     2539      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@987Nabil
Copy link
Contributor Author

@vigoo I set the test to ignore for now, since it blocks all work on the repo. I tried out some stuff that did not work.
It might has to do something with the truststore.jks? But I am not sure. I think I better focus on my open PRs.
I opened #2532 to keep track of this issue.

@987Nabil 987Nabil merged commit bc6c29b into zio:main Nov 24, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants