Error handling methods on Route/Routes that can access Request
#2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
987Nabil
force-pushed
the
error-handling-with-request-access
branch
3 times, most recently
from
743e301
to
ea5e790
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2546 +/- ##
==========================================
- Coverage 64.28% 64.27% -0.02%
==========================================
Files 138 138
Lines 7977 8013 +36
Branches 1483 1457 -26
==========================================
+ Hits 5128 5150 +22
- Misses 2849 2863 +14 ☔ View full report in Codecov by Sentry. |
987Nabil
force-pushed
the
error-handling-with-request-access
branch
from
ea5e790
to
d6dbc78
Compare
jdegoes
reviewed
Dec 7, 2023
| * used to convert a route that does not handle its errors into one that does | ||
| * handle its errors. | ||
| */ | ||
| final def handleErrorRequest(f: (Err, Request) => Response)(implicit trace: Trace): Route[Env, Nothing] = |
There was a problem hiding this comment.
One can argue that handleError with Request could be useful in non-cause scenarios, which would argue for the naming convention of handleError[Request][Cause].
There was a problem hiding this comment.
handleError[Request][Cause][ZIO]
Bug fix on Warning header
987Nabil
force-pushed
the
error-handling-with-request-access
branch
from
d6dbc78
to
43da2dd
Compare
jdegoes
approved these changes
Dec 8, 2023
jdegoes
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix on Warning header