Implement Routes#apply #2550
Merged
Implement Routes#apply #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgfraser
requested review from
amitksingh1490,
jdegoes,
vigoo and
987Nabil
as code owners
vigoo
approved these changes
Dec 8, 2023
|
I was pairing with a developer and we specifically needed an apply with no implicit evidence (i.e. polymorphic E). I thought it might be possible using an error type of Either[E, Response]. Namely by stuffing an E into a hidden defect Throwable and recovering at the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2548. /claim #2548
Route#applyis already implemented and returns aZIO[Env, Response, Response]so I think it makes sense forRoutes#applyto do so as well. Also, I don't think the more polymorphic variant is well defined since aRoutemay already have a middleware applied to it that is a function from handler to handler where the error type is already specialized toResponseand converting aCauseto aResponseis not information preserving.