Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcing maxInitialLineLength through the config and propagating it to netty's configuration #2561

Conversation

hdriviere
Copy link
Contributor

@hdriviere hdriviere commented Dec 15, 2023

Resolve #2560

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023

CLA assistant check
All committers have signed the CLA.

@hdriviere hdriviere force-pushed the feat/enhance-configurability-of-maxInitialLineLength branch from 27fc1d4 to bbb30eb Compare December 15, 2023 14:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f42676e) 64.76% compared to head (725ded7) 64.73%.

Files Patch % Lines
zio-http/src/main/scala/zio/http/Server.scala 0.00% 1 Missing ⚠️
zio-http/src/main/scala/zio/http/ZClient.scala 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2561      +/-   ##
==========================================
- Coverage   64.76%   64.73%   -0.03%     
==========================================
  Files         139      139              
  Lines        8128     8130       +2     
  Branches     1481     1488       +7     
==========================================
- Hits         5264     5263       -1     
- Misses       2864     2867       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdriviere hdriviere marked this pull request as ready for review December 15, 2023 15:15
@jdegoes jdegoes merged commit fa99f66 into zio:main Dec 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to enhance configurability of 'maxInitialLineLength'
4 participants