Fix #2622: don't remove 'val' from case classes' parameters with names containing 'val' in them #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekhov
requested review from
amitksingh1490,
jdegoes,
vigoo,
adamgfraser and
987Nabil
as code owners
ekhov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2634 +/- ##
=======================================
Coverage 64.89% 64.89%
=======================================
Files 144 144
Lines 8495 8495
Branches 1535 1535
=======================================
Hits 5513 5513
Misses 2982 2982 ☔ View full report in Codecov by Sentry. |
|
@ekhov please add a test |
ekhov
force-pushed
the
fix-val-removal-in-codegen
branch
from
c1be488
to
1fb1e1e
Compare
|
@987Nabil done! |
987Nabil
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #2622