Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to read oneOf, before handling empty schema type as Object (#2623) #2657

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

987Nabil
Copy link
Contributor

fixes #2623
/claim #2623

@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5c9b8c7) 65.26% compared to head (51de7a5) 65.38%.
Report is 2 commits behind head on main.

Files Patch % Lines
...n/scala/zio/http/endpoint/openapi/JsonSchema.scala 0.00% 6 Missing ⚠️
.../jvm/src/main/scala/zio/http/netty/NettyBody.scala 70.00% 3 Missing ⚠️
...ed/src/main/scala/zio/http/codec/QueryCodecs.scala 84.61% 2 Missing ⚠️
...scala/zio/http/codec/internal/EncoderDecoder.scala 91.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
+ Coverage   65.26%   65.38%   +0.12%     
==========================================
  Files         144      144              
  Lines        8427     8448      +21     
  Branches     1529     1531       +2     
==========================================
+ Hits         5500     5524      +24     
+ Misses       2927     2924       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit fbc3ddc into zio:main Jan 28, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect code generation for oneOf fields
3 participants