Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :Add raw in Html object #2668

Merged
merged 14 commits into from
Apr 5, 2024
Merged

Conversation

guptadeepak8
Copy link
Contributor

fix: #2651
/claim #2651

Copy link

algora-pbc bot commented Feb 8, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.56%. Comparing base (57502a1) to head (47e1cba).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2668   +/-   ##
=======================================
  Coverage   64.56%   64.56%           
=======================================
  Files         148      148           
  Lines        8649     8650    +1     
  Branches     1573     1573           
=======================================
+ Hits         5584     5585    +1     
  Misses       3065     3065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guptadeepak8 guptadeepak8 changed the title Fix :HTML rendering issue in Html.fromString method Fix :Add raw in Html object Feb 11, 2024
@guptadeepak8
Copy link
Contributor Author

@jdegoes can you review this

@jdegoes
Copy link
Member

jdegoes commented Feb 24, 2024

We need a test case, then looks good to merge!

@guptadeepak8
Copy link
Contributor Author

guptadeepak8 commented Mar 2, 2024

@jdegoes @987Nabil made changes can review this

@jdegoes jdegoes merged commit 9765d34 into zio:main Apr 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Html.fromString Behavior Change
4 participants