Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet Utils: Handle Exceptions When Running Docs Commands on The Root Project #2687

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

khajavi
Copy link
Member

@khajavi khajavi commented Feb 19, 2024

This PR makes the snippet utils work even when running docs commands on the root project. This is required when we need to publish docs on ci.

@khajavi khajavi added the documentation Improvements or additions to documentation label Feb 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1da91b) 64.56% compared to head (c82ac1a) 64.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2687   +/-   ##
=======================================
  Coverage   64.56%   64.56%           
=======================================
  Files         148      148           
  Lines        8649     8649           
  Branches     1573     1573           
=======================================
  Hits         5584     5584           
  Misses       3065     3065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khajavi
Copy link
Member Author

khajavi commented Feb 19, 2024

@adamgfraser This is ready for your review.

@adamgfraser adamgfraser merged commit 224388f into zio:main Feb 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants