Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(domain): add default headers in Response #37

Merged
merged 6 commits into from
Mar 16, 2021
Merged

fix(domain): add default headers in Response #37

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f5b498
fix(domain): add default headers in Response
d11-amitsingh Mar 16, 2021
6ea6ab1
fix(domain): add default headers in FullHttpResponse
d11-amitsingh Mar 16, 2021
a1dad2c
fix(http): Server_NAME should be allocated once
d11-amitsingh Mar 16, 2021
eeab93e
fix(http): rename Server_NAME to SERVER_NAME
d11-amitsingh Mar 16, 2021
c4585ba
fix(http): add Server_NAME in Response companion object
d11-amitsingh Mar 16, 2021
02bf932
fix(http): revert header changes
d11-amitsingh Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion zio-http/src/main/scala/zhttp/http/Response.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import zio.Task
import zio.stream.ZStream

import java.io.{PrintWriter, StringWriter}
import java.time.ZonedDateTime
import java.time.format.DateTimeFormatter

// RESPONSE
sealed trait Response extends Product with Serializable { self => }
Expand All @@ -34,6 +36,8 @@ object Response {
val jContentBytBuf = res.content match {
case HttpContent.Complete(data) =>
jHttpHeaders.set(JHttpHeaderNames.CONTENT_LENGTH, data.length())
jHttpHeaders.set(JHttpHeaderNames.SERVER, "zio-http")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zio-http can be moved up so that the string is allocated only once.

jHttpHeaders.set(JHttpHeaderNames.DATE, s"${DateTimeFormatter.RFC_1123_DATE_TIME.format(ZonedDateTime.now)}")
JUnpooled.copiedBuffer(data, HTTP_CHARSET)

case _ =>
Expand Down Expand Up @@ -97,7 +101,6 @@ object Response {
def jsonString(data: String): Response =
http(
content = HttpContent.Complete(data),
headers = List(Header.contentTypeJson),
)

def status(status: Status): Response = http(status)
Expand Down