Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing extraneous generic parameter from Server #57

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Removing extraneous generic parameter from Server #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions zio-http/src/main/scala/zhttp/service/Server.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import zhttp.http._
import zhttp.service.server.{ServerChannelFactory, ServerChannelInitializer, ServerRequestHandler}
import zio._

final class Server[R](serverBootstrap: JServerBootstrap, init: JChannelInitializer[JChannel]) { self =>
final class Server(serverBootstrap: JServerBootstrap, init: JChannelInitializer[JChannel]) { self =>

/**
* Starts the server on the provided port
Expand All @@ -16,7 +16,7 @@ final class Server[R](serverBootstrap: JServerBootstrap, init: JChannelInitializ
}

object Server {
def make[R, E: SilentResponse](http: HttpApp[R, E]): ZIO[R with EventLoopGroup, Throwable, Server[R]] =
def make[R, E: SilentResponse](http: HttpApp[R, E]): ZIO[R with EventLoopGroup, Throwable, Server] =
for {
zExec <- UnsafeChannelExecutor.make[R]
channelFactory <- ServerChannelFactory.Live.auto
Expand Down