Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Return Start on server start #682

Merged
merged 23 commits into from
Jan 6, 2022
Merged

Feature: Return Start on server start #682

merged 23 commits into from
Jan 6, 2022

Conversation

girdharshubham
Copy link
Member

Closes #633

@girdharshubham girdharshubham self-assigned this Dec 23, 2021
@github-actions github-actions bot added the enhancement New feature or request label Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #682 (ed32dce) into main (d1f9d8b) will increase coverage by 0.16%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   49.83%   50.00%   +0.16%     
==========================================
  Files          69       69              
  Lines        2061     2064       +3     
  Branches       52       50       -2     
==========================================
+ Hits         1027     1032       +5     
+ Misses       1034     1032       -2     
Impacted Files Coverage Δ
zio-http/src/main/scala/zhttp/service/Server.scala 56.00% <80.00%> (+4.93%) ⬆️
...cala/zhttp/service/server/LeakDetectionLevel.scala 50.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f9d8b...ed32dce. Read the comment docs.

@amitksingh1490
Copy link
Collaborator

🚀🚀🚀 Benchmark Results

Concurrency: 256
Requests/sec: 436891.79

@zio zio deleted a comment from amitksingh1490 Dec 23, 2021
@zio zio deleted a comment from amitksingh1490 Dec 23, 2021
@girdharshubham girdharshubham force-pushed the feat/server-port branch 3 times, most recently from 63ac14f to bf0985a Compare December 27, 2021 15:51
@girdharshubham girdharshubham marked this pull request as ready for review December 27, 2021 15:53
@tusharmath tusharmath merged commit fddb458 into main Jan 6, 2022
@tusharmath tusharmath deleted the feat/server-port branch January 6, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return the server start on starting the server
4 participants