Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response Json headers #750

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Response Json headers #750

merged 3 commits into from
Jan 3, 2022

Conversation

amitksingh1490
Copy link
Collaborator

Fixes #747

@github-actions github-actions bot added the bug Something isn't working label Jan 3, 2022
@amitksingh1490 amitksingh1490 enabled auto-merge (squash) January 3, 2022 14:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022 •
edited

Codecov Report

Merging #750 (fc812d9) into main (03881d9) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   49.56%   49.85%   +0.28%     
==========================================
  Files          68       68              
  Lines        2074     2074              
  Branches       58       58              
==========================================
+ Hits         1028     1034       +6     
+ Misses       1046     1040       -6
Impacted Files Coverage Δ
zio-http/src/main/scala/zhttp/http/Response.scala 69.23% <100.00%> (+9.61%) ⬆️
.../scala/zhttp/http/headers/HeaderConstructors.scala 18.07% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03881d9...fc812d9. Read the comment docs.

tusharmath
tusharmath requested changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@tusharmath tusharmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick change.

@amitksingh1490
Copy link
Collaborator Author

Some quick change.

Done

@amitksingh1490 amitksingh1490 merged commit 0c2758c into main Jan 3, 2022
@amitksingh1490 amitksingh1490 deleted the fix/747 branch January 3, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Header set in Response.json
3 participants
@amitksingh1490 @codecov-commenter @tusharmath