Refactor: Remove type params from HttpData #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 49.63% 49.83% +0.19%
==========================================
Files 69 69
Lines 2069 2067 -2
Branches 52 55 +3
==========================================
+ Hits 1027 1030 +3
+ Misses 1042 1037 -5
Continue to review full report at Codecov.
|
| * Creates a Http that always succeeds with a 200 status code and the provided ZStream as the body | ||
| */ | ||
| def fromStream[R](stream: ZStream[R, Throwable, Byte]): HttpApp[R, Nothing] = | ||
| Http.fromEffect(ZIO.environment[R].map(r => Http.fromData(HttpData.fromStream(stream.provide(r))))).flatten |
There was a problem hiding this comment.
I am not sure what will be the impact on Performance here.
There was a problem hiding this comment.
We will need to benchmark this. Irrespective of that, in production people will use provide anyways at places.
Co-authored-by: Amit Kumar Singh <amit.singh@dream11.com>
amitksingh1490
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpData was unnecessary complex with type-parameters. This also help in our final goal of ultimately removing type-params from Response.
Feature
fromStreamoperator toHttp