Use java map i.s.o. scala map #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, note that this code is also changed by #1067. |
guizmaii
reviewed
Oct 13, 2023
| commit.offsets.foreach { case (tp, offset) => | ||
| acc += (tp -> acc.get(tp).map(_ max offset).getOrElse(offset)) | ||
| acc.merge(tp, offset, _ max _) |
There was a problem hiding this comment.
For once Java provides a nicer operator than Scala 🙂
There was a problem hiding this comment.
Indeed! 😄
There is also:
acc.updateWith(tp) { current => current.map(_ max offset).orElse(Some(offset)) }But definitely less nice.
There was a problem hiding this comment.
You inspired me to write: scala/scala-library-next#164 😄
|
Closing as this is just a demonstration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1073 (comment) this PR explores using a java HashMap directly.
Note that we still need to convert to scala map for doing the +1 on offsets, and we still need to convert to an immutable map for diagnostics.
This PR is probably a bit faster, but it does feel weird: constructing a Java map, converting it to Scala and then back to java.