Improve support and documentation for manual offsets #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvanoosten
force-pushed
the
doc-offset-retrieval
branch
from
d0123ea
to
b09383b
Compare
…t falls back to the `auto.offset.reset` configuration. In this change we allow the user to set that configuration when `Manual` offset retrieval is used. This PR also contains a behavior change. For Manual offsets, when no offset is given by the user, before we would skip the records from the first poll. After this change those are no longer skipped. In addition, add documentation on how to configure offset retrieval. Note: this change is source compatible, but not binary compatible.
erikvanoosten
force-pushed
the
doc-offset-retrieval
branch
from
b09383b
to
87e30f7
Compare
erikvanoosten
changed the title
erikvanoosten
changed the title
erikvanoosten
changed the title
svroonland
reviewed
Dec 17, 2023
| getOffsets(tps).flatMap { offsets => | ||
| ZIO | ||
| .attempt(offsets.foreach { case (tp, offset) => c.seek(tp, offset) }) | ||
| .as(offsets.keySet) |
There was a problem hiding this comment.
This relates to this part of the PR description:
This PR also contains a behavior change. For Manual offsets, when no offset is given by the user, before we would skip the records from the first poll. After this change those are no longer skipped.
There was a problem hiding this comment.
And also to this part:
Furthermore, testing showed that we fall back to 'Auto' behavior when no offset is given.
Basically, how it was before we would loose data for this particular edge case.
There was a problem hiding this comment.
Ah I see how the method is being used now. It could use a comment what the return value means.
There was a problem hiding this comment.
Indeed, I'll add that.
svroonland
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the javadoc of
seek, when a given offset is invalid, it falls back to theauto.offset.resetconfiguration. In this change we allow the user to set that configuration whenManualoffset retrieval is used. Furthermore, testing showed that we fall back to 'Auto' behavior when no offset is given.This PR also contains a behavior change. For Manual offsets, when no offset is given by the user, before we would skip the records from the first poll. After this change those are no longer skipped.
In addition, add documentation on how to configure offset retrieval.
Note: this change is source compatible, but not binary compatible.