Serde followups #44
Merged
Serde followups #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svroonland
approved these changes
Oct 4, 2019
| def deserializeWith[R, K1, V1]( | ||
| keyDeserializer: Deserializer[R, K1], | ||
| valueDeserializer: Deserializer[R, V1] | ||
| )(implicit ev1: K <:< Array[Byte], ev2: V <:< Array[Byte]): RIO[R, CommittableRecord[K1, V1]] = |
There was a problem hiding this comment.
Interesting trick this subtype evidence, never used it before.
| @@ -93,8 +93,8 @@ object Producer { | |||
| r: ProducerRecord[K, V] | |||
| ): RIO[R, ByteArrayProducerRecord] = | |||
| for { | |||
| key <- keySerializer.serialize(r.key()) | |||
| value <- valueSerializer.serialize(r.value()) | |||
| key <- keySerializer.serialize(r.topic, r.headers, r.key()) | |||
There was a problem hiding this comment.
👍
I never saw the need for the serializer to know the topic and headers, but I like the idea of not imposing that.
| /** | ||
| * Obtain an instance of a Serializer of some type from the implicit scope | ||
| */ | ||
| def of[T](implicit ser: Serializer[Any, T]): Serializer[Any, T] = ser |
There was a problem hiding this comment.
Any particular reason for removing the ofs?
There was a problem hiding this comment.
I'd like to move away from encouraging users to use implicit scope for the serializer/deserializer instances.
In other words - not treat them like typeclasses at all, but rather as simple functions.
| @@ -48,7 +48,7 @@ class ConsumerTest extends WordSpecLike with Matchers with LazyLogging with Defa | |||
| _ <- consumer.subscribe(Subscription.Topics(Set("topic150"))) | |||
| kvs <- ZIO((1 to 5).toList.map(i => (s"key$i", s"msg$i"))) | |||
| _ <- produceMany("topic150", kvs) | |||
| records <- consumer.plainStream(Serde.of[String], Serde.of[String]).flattenChunks.take(5).runCollect | |||
| records <- consumer.plainStream(Serde.string, Serde.string).flattenChunks.take(5).runCollect | |||
There was a problem hiding this comment.
Agreed that for the primitive serdes there's no advantage of Serde.of[String] over Serde.string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@svroonland - could you have a look?