Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Serializer#asOption #470

Merged
merged 7 commits into from Sep 23, 2022
Merged

Fix Serializer#asOption #470

merged 7 commits into from Sep 23, 2022

Conversation

svroonland
Copy link
Collaborator

@svroonland svroonland commented May 24, 2022 •
edited

It would pass null to the inner serializer, which would expect some non-primitive type T and might throw null pointer exceptions.

@svroonland svroonland marked this pull request as ready for review May 24, 2022 15:16
@svroonland svroonland requested a review from iravid as a code owner May 24, 2022 15:16
@vigoo vigoo merged commit a31c415 into master Sep 23, 2022
@vigoo vigoo deleted the fix-as-option branch September 23, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigoo vigoo vigoo approved these changes

@iravid iravid Awaiting requested review from iravid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svroonland @vigoo