Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a batching sink #48

Merged
merged 4 commits into from Oct 5, 2019
Merged

Add a batching sink #48

merged 4 commits into from Oct 5, 2019

Conversation

andreamarcolin
Copy link
Contributor

Implements #32

andreamarcolin and others added 2 commits October 5, 2019 15:44
@andreamarcolin @iravid
Update src/main/scala/zio/kafka/client/Consumer.scala
604839a 
Addressing review comment

Co-Authored-By: Itamar Ravid <iravid@users.noreply.github.com>
@andreamarcolin
Oops, fix last commit
33b95fb
iravid
iravid previously approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreamarcolin!

@iravid
Copy link
Member

iravid commented Oct 5, 2019

Needs a rebase

@iravid iravid merged commit 1ba61a7 into zio:master Oct 5, 2019
@andreamarcolin andreamarcolin deleted the batching-sink branch October 5, 2019 15:54
@iravid iravid mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iravid iravid iravid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreamarcolin @iravid