Rename the zio-kafka-test-utils module to zio-kafka-testkit && change its base package from zio.kafka to zio.kafka.testkit
#845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
force-pushed
the
rename_testkit_module
branch
3 times, most recently
from
713c1bd
to
65c864a
Compare
svroonland
reviewed
May 12, 2023
erikvanoosten
previously approved these changes
May 14, 2023
There was a problem hiding this comment.
@guizmaii convinced me that we can make this change; only power-users have found their way to test-utils yet. Together with proper documentation, we can make the switch.
|
@svroonland See my answer to Erik on Discord: https://discord.com/channels/629491597070827530/629497941719121960/1107265058695815168 Let me know what you think :) |
2 tasks
guizmaii
force-pushed
the
rename_testkit_module
branch
from
3c1a2e8
to
2e72287
Compare
guizmaii
changed the title
zio-kafka-test-utils module to zio-kafka-testkit to make it more explicit that it's something that can be used by zio-kafka userszio-kafka-test-utils module to zio-kafka-testkit && change its base package from zio.kafka to zio.kafka.testkit
guizmaii
force-pushed
the
rename_testkit_module
branch
from
2e72287
to
6bc6ace
Compare
…ke it more explicit that it's something that can be used by zio-kafka users Also, change the base namespace of this module from `zio.kafka` to `zio.kafka.testkit` to make things more explicit
guizmaii
force-pushed
the
rename_testkit_module
branch
from
6bc6ace
to
e1613c4
Compare
erikvanoosten
approved these changes
May 21, 2023
There was a problem hiding this comment.
Just one comment. I am fine with merging this PR with #846.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new name, I want to make this package more easily discoverable by our users.
The package change is to better separate things between zio-kafka and its testkit