[Internal] Clean some code #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
force-pushed
the
clean_code
branch
4 times, most recently
from
354c953
to
4012c2a
Compare
erikvanoosten
approved these changes
May 26, 2023
There was a problem hiding this comment.
Merging #830 is going to be harder and harder. Anyways, these are good changes.
| @@ -568,7 +560,7 @@ private[consumer] object Runloop { | |||
| } | |||
| } | |||
|
|
|||
| def apply( | |||
| def make( | |||
I advise you to rebase on It'll be simpler for you to rebase #830 after my big PR if you first rebase on master after this last small PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.