Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swim refactor #176

Merged
merged 65 commits into from
Apr 18, 2020
Merged

Swim refactor #176

merged 65 commits into from
Apr 18, 2020

Conversation

pshemass
Copy link
Contributor

No description provided.

@pshemass
move messages to membership
8309c30
@pshemass
break down protocols
a9e1de2
@pshemass
pretty nice version of runner
07ff9c8
@pshemass
remove reply
2f2a07b
@pshemass
extract nodes
a4820a0
@pshemass
move staff to Nodes
13ef63b
@pshemass
implement swim
5589093
@pshemass
simpler protocol
1564988
@pshemass
working example
94c1d75
@pshemass
remove A from interface
94820bd
@pshemass
migrate to new zio-nio
797f039
@pshemass
one round for failure detection
137bbc8
@pshemass
synchronized read and write in transport
df73815
@pshemass
fix protocol round
d17bca9
@pshemass
suspicion part
f973c9b
@pshemass
remove explicit state from messages
5cb9794
@pshemass
Enriched message added
1e888d3
@pshemass
Enreached message serialization and clean up
a946b43
@pshemass
revert changes in membership package
c6712c7
@pshemass
formatting
455e6d6
@pshemass
fix queue shutdown, and user protocol serialization
4d08804
@pshemass
back to NodeId
c4eb5a4
@pshemass
add correlation id
745a53c
@pshemass
scaladoc and cleanup
4de9cfa
@pshemass
add events when node state changed
3dea169
@pshemass
more scala docs
1939273
@pshemass
handle errors on connection
280a3b4
mijicd
mijicd reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the first pass. I will make another pass later. Didn't want to repeat myself too much, but from the cosmetic side of the world you can:

  • use aliases (Stream, IO etc.) rather than Z-fellas :)
  • make case classes final

keeper/src/main/scala/zio/keeper/TaggedCodec.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/TaggedCodec.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/TaggedCodec.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/ByteCodec.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/errors.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/NodeId.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/Nodes.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/Protocol.scala Show resolved Hide resolved
@pshemass pshemass changed the title WIP Swim refactor Swim refactor Apr 13, 2020
@pshemass
Copy link
Contributor Author

@mijicd @mschuwalow work is done to the point I feel comfortable to merge it. I plan to add config for SWIM, layers for Nodes and Messages and probably improve Broadcast a little bit but after we figure out what to do with Transport

I need to look why tests are hanging on CI. I run them more than 10 times locally and I couldn't have reproduced it. Maybe this is something with UDP.

mijicd
mijicd reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! I've made some remarks and tried to do the annoying ones as commit suggestions.

keeper/src/main/scala/zio/keeper/membership/NodeAddress.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/NodeAddress.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/Broadcast.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/Broadcast.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/Broadcast.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/SWIM.scala Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/SWIM.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/SWIM.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/protocols/FailureDetection.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/protocols/User.scala Outdated Show resolved Hide resolved
mschuwalow
mschuwalow reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@mschuwalow mschuwalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll take a close look tomorrow

keeper/src/main/scala/zio/keeper/membership/NodeAddress.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/Message.scala Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/transport/package.scala Outdated Show resolved Hide resolved
keeper/src/main/scala/zio/keeper/membership/swim/protocols/Suspicion.scala Outdated Show resolved Hide resolved
@mijicd mijicd merged commit d4d7aea into zio:master Apr 18, 2020
@pshemass pshemass mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iravid iravid iravid left review comments

@mschuwalow mschuwalow mschuwalow left review comments

@mijicd mijicd mijicd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pshemass @CLAassistant @iravid @mijicd @mschuwalow