New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Throwables are null #510

Closed

gkfabs opened this issue Sep 15, 2022 · 1 comment · Fixed by #511

gkfabs commented Sep 15, 2022

In log functions (debug, trace, etc...) we never check if the throwable is null. We could then use the pure string version (debug, trace, etc...)

It seems to be a common practice in java library where those functions can be used with a null throwable (netty)

gkfabs mentioned this issue

GenericAwsError when trying to connecting to Sqs zio/zio-sqs#643

Closed

Contributor

justcoon commented Sep 15, 2022

hi @gkfabs , thanks for report, we will add check for that ...

justcoon mentioned this issue

slf4j bridge - null Throwable as empty Cause #511

Merged

justcoon closed this as completed in #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment