Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split project into modules (statsd, newrelic, prometheus, datadog) #40

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

calvinlfer
Copy link
Member

@calvinlfer calvinlfer commented May 20, 2023

  • Update libraries (ZIO HTTP & ZIO JSON)
  • Update Scala 3 version
  • Update SBT

Closes #2
Closes #3

@calvinlfer calvinlfer changed the title Split projects into modules Split project into modules (statsd, newrelic, prometheus, datadog) May 20, 2023
@calvinlfer calvinlfer force-pushed the split-modules branch 2 times, most recently from c93c8b2 to 8797495 Compare June 12, 2023 17:47
@petoalbert
Copy link
Collaborator

petoalbert commented Jun 14, 2023

Nice changes @calvinlfer! Thank you! I can merge this once you fixed the merge conflicts.

Would you like to update the documentation in this PR too? I am thinking that we should mention here the additional artifacts have to be specified in the dependencies.

@calvinlfer
Copy link
Member Author

Nice changes @calvinlfer! Thank you! I can merge this once you fixed the merge conflicts.

Would you like to update the documentation in this PR too? I am thinking that we should mention here the additional artifacts have to be specified in the dependencies.

Hey @petoalbert, afaik you don't need to include any additional dependencies for prometheus, its fully self-contained since we build the strings within the library. It's on the user to expose the strings for scraping via a web endpoint. Is that the documentation you are after?

* Update libraries (ZIO HTTP & ZIO JSON)
* Update Scala 3 version
* Update SBT
@calvinlfer
Copy link
Member Author

I've pulled all examples into the sample project module

@petoalbert
Copy link
Collaborator

petoalbert commented Jun 19, 2023

@calvinlfer I meant that the documentation for the prometheus client should mention that the first step to use the module should be to specify dev.zio:zio-metrics-connectors-prometheus as a dependency, and the same for every other metric client. Currently the only artefact mentioned in the documentation is here.

@petoalbert
Copy link
Collaborator

I am happy to merge this now and create an issue to track the documentation. 🙂

@petoalbert petoalbert merged commit 5daea9d into zio:zio/series2.x Jun 19, 2023
13 checks passed
@petoalbert
Copy link
Collaborator

@calvinlfer #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create submodules for newrelic, prometheus, statsd remove "io.d11" % "zhttp" from dependencies
2 participants