-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split project into modules (statsd, newrelic, prometheus, datadog) #40
Conversation
c93c8b2
to
8797495
Compare
Nice changes @calvinlfer! Thank you! I can merge this once you fixed the merge conflicts. Would you like to update the documentation in this PR too? I am thinking that we should mention here the additional artifacts have to be specified in the dependencies. |
Hey @petoalbert, afaik you don't need to include any additional dependencies for prometheus, its fully self-contained since we build the strings within the library. It's on the user to expose the strings for scraping via a web endpoint. Is that the documentation you are after? |
* Update libraries (ZIO HTTP & ZIO JSON) * Update Scala 3 version * Update SBT
8797495
to
c5bcb6d
Compare
I've pulled all examples into the sample project module |
@calvinlfer I meant that the documentation for the prometheus client should mention that the first step to use the module should be to specify |
I am happy to merge this now and create an issue to track the documentation. 🙂 |
Closes #2
Closes #3