Expose the entity id to allow using Datadog origin detection #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oridag
reviewed
Nov 21, 2023
datadog/src/main/scala/zio/metrics/connectors/datadog/DatadogEncoder.scala
Outdated
Show resolved
Hide resolved
oridag
reviewed
Nov 21, 2023
datadog/src/main/scala/zio/metrics/connectors/datadog/DatadogEncoder.scala
Outdated
Show resolved
Hide resolved
oridag
approved these changes
Nov 21, 2023
petoalbert
approved these changes
Nov 22, 2023
|
@petoalbert would it be possible to do a release soon? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
entityIdthat is added as a tag and allow using Datadog origin detection.In the original implementation they are getting it from the
DD_ENTITY_IDenvironment variable if not provided. I didn't do it in order to mimic thecontainerIdbehavior, and this can be done in user code anyway.Because
DatadogEncodercan't modify tags, I modifiedStatsdEncoderto allow passing constant tags that are added to every metric event. Using aStringis more efficient than adding tags as it doesn't need to be formatted every time. The dogstatsd has a similar approach.