Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ZIO 2.0.0 final #23

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Migrate to ZIO 2.0.0 final #23

merged 4 commits into from
Jun 28, 2022

Conversation

reibitto
Copy link
Contributor

I started the migration to ZIO 2.0.0 final but I ran into many roadblocks so this is still in an incomplete state. The compile errors regarding macros are beyond my ability.

@vigoo @adamgfraser Whether you want to use this as a base or throw it away, either is fine with me. Just thought I'd publish what I have so far regardless.

@vigoo
Copy link
Contributor

vigoo commented Jun 27, 2022

Thanks for starting it!

@vigoo
Copy link
Contributor

vigoo commented Jun 28, 2022

@reibitto I fixed the unsafes, there are still some failing tests and compilation error on Scala Native, feel free to continue as I don't have more time right now for this

@reibitto
Copy link
Contributor Author

I pushed an update that should fix a bunch of the failing tests. JVM modules seem fine to me locally now. I don't know about scala-native though. Still can't get that to compile.

@reibitto
Copy link
Contributor Author

Oh wait, JVM and native is good now in CI. JS is the one that has an issue. Looks like SecureRandom isn't available on Scala.js by default?

@reibitto
Copy link
Contributor Author

ok, adding "org.scala-js" %%% "scalajs-java-securerandom" % "1.0.0" fixed that last error. That same dependency is in the main zio project so I assume it's fine?

Everything is green now. Might want to make sure my change in MockClock to support the currentTime overload is correct. I wasn't too sure about that. I followed one of the examples in the tests.

@reibitto reibitto marked this pull request as ready for review June 28, 2022 12:23
@vigoo
Copy link
Contributor

vigoo commented Jun 28, 2022

Looks good to me, I'm merging and releasing it. Thank you!

@vigoo vigoo merged commit 664a1e4 into zio:master Jun 28, 2022
@reibitto reibitto deleted the zio2.0.0-final branch June 28, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants