Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore ReporterSpec tests #51

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Conversation

regiskuckaertz
Copy link
Member

No description provided.

@regiskuckaertz
Copy link
Member Author

whoops, loads of failures in the JS and Scala 3 area. What do you think @adamgfraser ?

@adamgfraser
Copy link
Contributor

@regiskuckaertz It looks like you need to upgrade some dependencies.

@regiskuckaertz
Copy link
Member Author

@adamgfraser look at all that green!

@regiskuckaertz
Copy link
Member Author

not sure how to fix that README error, I ran locally but the <version> thing won't be replaced with whatever it needs to be

@adamgfraser
Copy link
Contributor

@regiskuckaertz You need to use the SBT plugin to generate the file, not update it yourself manually.

@regiskuckaertz
Copy link
Member Author

I did runs the docs/generateReadme as indicated twice but same result. Is it looking for something in the environment?

@adamgfraser
Copy link
Contributor

@regiskuckaertz Your changes are not consistent with running docs/generateReadme. See #52.

@regiskuckaertz
Copy link
Member Author

@adamgfraser all clear!

@adamgfraser adamgfraser merged commit ed2b59f into zio:master Nov 16, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants