Added Closure and Associative Instances #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KamalKang
commented
Mar 29, 2020
KamalKang
commented
- Created instances for Closure and Associative
- Removed combine operator from Identity as it was redundant.
added 4 commits
March 28, 2020 19:41
1) Added Implicit instances for Closure and Associative 2) Remove combine operator in Identity
adamgfraser
suggested changes
Mar 29, 2020
There was a problem hiding this comment.
@KamalKang Looks great! A couple of minor comments and then this will be ready to merge.
mijicd
reviewed
Mar 29, 2020
KamalKang
changed the title
|
@adamgfraser and @mijicd - Took care of all the comments. Removed EitherClosure and EitherAssociative for now. |
This was referenced Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.