debug

[ghost]

#1

I was trying to add both and bothWith and Either for this one. but im not sure how to compose two Reprs.

[adamgfraser]

@sken77 This looks like a good start.

I don't think we can implement bothWith or eitherWith for Debug, at least in their pure forms. The issue is that Debug requires too much information that is not captures in the types of the elements. For example, consider:

final case class Engineer(name: String, salary: Int)
final case class Architect(name: String, salary: Int)

For something like Equal if we have a product type with two elements we can always compare it for equality if we have a way to compare each of the elements. It doesn't matter if it is a Engineer or an Architect if we can compare names and salaries we can say whether one engineer is equal to another or one architect is equal to another.

But this isn't true for Debug because we also need to know the prefix. We could require the user to provide another parameter for the prefix and use that with Repr.VConstructor and similarly require the user to provide a prefix for the different cases in eitherWith. May be worth thinking about how we could provide combinators like that to make it more ergonomic for users to construct instances but we should probably not use the bothWith and eitherWith names because of these differences.

[ghost]

Yeah thats what i thought. I'll finish the rest of the Tuples with something similar i did for Tuple2.

[ghost]

So i just talked with @jaliss . he will add the Tuples on a different PR. so this one is good to go. @adamgfraser I think the other point to that the law of debug is symmetry? i recall that @jdegoes said on class that we should be parse the output into scala code. but that seems to be a much bigger issue outside of the scope of this issue

[adamgfraser]

Yes, I think adding full support for that is going to require adding some functionality for doing runtime compilation which I think is doable but agree is outside the scope of this PR.

[adamgfraser]

@sken77 Could we add a default renderer and some basic tests that rendering simple values results in the expected string?

[ghost]

Sure thing

[adamgfraser]

Awesome!

[ghost]

Im having issues with the GenList test. for some reason its generating 4 different lists. thats why the test isnt passing. I post this progress just to check the toString call looks ok

[adamgfraser]

@sken77 Will take a look in a little while.

[ghost]

#5 this pr also deals with this one

[ghost]

huh thats weird. fmt passed on my end

[ghost]

I cant see the details since its prolly private in Circle

[jdegoes]

@sken77 Can you resolve conflicts and make sure tests pass manually, then we can get this one merged in?

[ghost]

@jdegoes ok this is good to go

[jdegoes]

@sken77 Thank you!