-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug #58
debug #58
Conversation
@sken77 This looks like a good start. I don't think we can implement final case class Engineer(name: String, salary: Int)
final case class Architect(name: String, salary: Int) For something like But this isn't true for |
Yeah thats what i thought. I'll finish the rest of the Tuples with something similar i did for |
So i just talked with @jaliss . he will add the Tuples on a different PR. so this one is good to go. @adamgfraser I think the other point to that the law of debug is symmetry? i recall that @jdegoes said on class that we should be parse the output into scala code. but that seems to be a much bigger issue outside of the scope of this issue |
Yes, I think adding full support for that is going to require adding some functionality for doing runtime compilation which I think is doable but agree is outside the scope of this PR. |
@sken77 Could we add a default renderer and some basic tests that rendering simple values results in the expected string? |
Sure thing |
Awesome! |
Im having issues with the GenList test. for some reason its generating 4 different lists. thats why the test isnt passing. I post this progress just to check the |
@sken77 Will take a look in a little while. |
#5 this pr also deals with this one |
huh thats weird. fmt passed on my end |
I cant see the details since its prolly private in Circle |
@sken77 Can you resolve conflicts and make sure tests pass manually, then we can get this one merged in? |
@jdegoes ok this is good to go |
@sken77 Thank you! |
#1
I was trying to add
both
andbothWith
and Either for this one. but im not sure how to compose twoRepr
s.