Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Specialized Variants For Effectual Folds Over Recursive Data Structures #854

Closed
wants to merge 1 commit into from
Closed

Create Specialized Variants For Effectual Folds Over Recursive Data Structures #854

wants to merge 1 commit into from

Conversation

adamgfraser
Copy link
Contributor

We can make these operators more accessible by creating specialized methods for various ZIO data types in addition to the more general foldM.

@adamgfraser adamgfraser requested a review from a team as a code owner January 22, 2022 19:02
sideeffffect
sideeffffect reviewed Jan 22, 2022
View reviewed changes
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But why don't we target master instead of zio-2? 🤔

@adamgfraser
Copy link
Contributor Author

@sideeffffect I think we're just starting to diverge between the two branches with ZEnvironment in ZIO 2.0 and the way Annotated is encoded with it so thought it made sense to do new development on this branch though this particular change would be fine on both versions.

@sideeffffect
Copy link
Member

In that case, I think it would be better to target master and continue merging master to zio-2 as we've been doing so far. What do you think?

@adamgfraser
Copy link
Contributor Author

Sure.

@adamgfraser adamgfraser deleted the recursive branch January 22, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideeffffect sideeffffect sideeffffect left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamgfraser @sideeffffect