Fixed bug where alias of filter clause did not match alias of inner query. #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed issue where a filter on an entity in a map was trying to nest the inner query, even though the filter also referred to the outside entity. |
guitaristmo
force-pushed
the
master
branch
3 times, most recently
from
7284b8f
to
56646d5
Compare
…clauses to the existing flattenSqlQuery if the aliases in the clauses are compatible. Added two tests for embedded filter and sortBy Cleaned up last test in ExpandNestedQueriesSpec
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An embedded filter where the filter had a different alias than the query, if it was not placed after a .nested, would throw an exception as the filter alias would be different than the alias of the query, and the query was not being wrapped up.
Solution
Only add the filter clause directly into the existing flattenSqlQuery if the filter alias matched an alias of one of the fromContext's.
Do so by adding a condition in the filter case to check the alias before adding the clause directly into the base flattenSqlQuery.
Otherwise, nest the inner query just like if there was already an existent filter clause.
Same for SortBy.
@getquill/maintainers