* accept unicode arrows #257
Conversation
| @@ -350,8 +350,10 @@ trait Parsing extends SchemaConfigParsing { | |||
| Delete(astParser(query)) | |||
| } | |||
|
|
|||
| private val arrow = pq"→|->" | |||
There was a problem hiding this comment.
out of curiosity, what is the pq interpolator?
There was a problem hiding this comment.
pattern interpolator, the cleanest way I found to support both arrows without code duplication :)
|
👍 |
|
I don't really understand why the build failed. I ran all the tests before creating the PR :-/ |
|
|
|
yes, you are right. I'm afraid it might be be an issue with scoverage and UTF-8 encoding. I will confirm it tomorrow and submit an issue/PR to scoverage if appropriate. |
|
@lvicentesanchez Seems related to this |
lvicentesanchez
force-pushed
the
issues/241
branch
from
feef4d6
to
31d1925
Compare
| @@ -54,3 +54,4 @@ sbt: | |||
| - TRAVIS_PULL_REQUEST | |||
| - TRAVIS_BRANCH | |||
| - ENCRYPTION_PASSWORD | |||
| - SBT_OPTS=-Dfile.encoding=UTF-8 -Xms512m -Xmx1536m -Xss2m -XX:ReservedCodeCacheSize=256m -XX:+TieredCompilation -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC | |||
There was a problem hiding this comment.
This fixed the encoding issue... I have used the default options that sbt-extras is using + encoding.
|
@jilen I solved it by forcing UTF-8 as the encoding for sbt. Once they publish a new version with the actual fix, we can upgrade and remove my workaround :) |
|
👍 |
|
@lvicentesanchez Can you change |
|
@gustavoamigo good catch! I will make the change there too :) |
lvicentesanchez
force-pushed
the
issues/241
branch
from
31d1925
to
42855f4
Compare
|
ok... there is something weird going on with this PR. Last 2 build shown an error that has nothing to do with my changes. I'm trying to build the PR again. If everything goes ok, I will rebase it and force pull a new version. |
|
Ok... so I re-run the build and no problems. The error was related to finagle-async and serialization; it seems to be a transient serialization issue related to the nr of file descriptors. Does everybody agree with the introduction of the |
lvicentesanchez
force-pushed
the
issues/241
branch
from
42855f4
to
a983ebd
Compare
|
👍 |
1 similar comment
|
👍 |
|
👍 |
* accept unicode arrows
|
good job |
Fixes #241
Problem
An unicode arrow, →, in a partial insert or update will make the parser to fail.
Solution
Modify the parser to accept both a single arrow, ->, or its unicode variant, →.
Notes
Closes #241.
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormatto make sure that the source files are formatted@getquill/maintainers