Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql onconflict update with renames #2708

Merged
merged 4 commits into from Jul 1, 2023

Conversation

joelsonoda
Copy link
Contributor

@joelsonoda joelsonoda commented Feb 21, 2023

Fixes #2707

Problem

When using onConflictUpdate with the mysql dialect, the values inserted were not being referenced correctly.

Solution

  • Updated the onConflict tests to use querySchema, schemaMeta and query.
  • Update mysql dialect to use values for renamed columns

Notes

Not sure if there is a cleaner way to test the same things using query, querySchema and schemaMeta.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2023

CLA assistant check
All committers have signed the CLA.

@joelsonoda joelsonoda force-pushed the mysql-onconflict-update-with-renames branch from 0cdef14 to b332011 Compare February 21, 2023 16:34
@joelsonoda joelsonoda changed the title Mysql onconflict update with renames (#2707) Mysql onconflict update with renames Feb 21, 2023
build/Dockerfile-setup Outdated Show resolved Hide resolved
@guizmaii
Copy link
Member

@joelsonoda is your work ready for review?

@joelsonoda
Copy link
Contributor Author

@guizmaii , I believe it is, unless I should squash the commit for applying the scalafmtAll first

…Use values for renamed columns in onConflictUpdate. (zio#2707)
@joelsonoda joelsonoda force-pushed the mysql-onconflict-update-with-renames branch from 856b1bd to 80aefbc Compare June 27, 2023 21:54
@joelsonoda
Copy link
Contributor Author

@guizmaii , I think that the code is ready for review, but I haven't been able to determine why the scala 2.13 async check is timing out.
I can produce the same result locally. I don't believe that this is isolated to my branch.

Do you have any suggestions on how to resolve this issue?

@guizmaii
Copy link
Member

Do you have any suggestions on how to resolve this issue?

I'm sorry I don't. Maybe @juliano?

@juliano
Copy link
Collaborator

juliano commented Jun 29, 2023

I am not sure, I'm under the impression this is related to the latest scala 2.13 OR to #2633 . I don't have much free time atm, will see if I can find some to have a look

Copy link
Collaborator

@juliano juliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, it looks good to me! @guizmaii can you please double check?

@juliano juliano merged commit 7528fd0 into zio:master Jul 1, 2023
19 checks passed
@juliano
Copy link
Collaborator

juliano commented Jul 1, 2023

Thank you @joelsonoda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL onConflictUpdate with column renames
4 participants