New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mysql onconflict update with renames #2708
Mysql onconflict update with renames #2708
Conversation
0cdef14
to
b332011
Compare
@joelsonoda is your work ready for review? |
@guizmaii , I believe it is, unless I should squash the commit for applying the |
…Use values for renamed columns in onConflictUpdate. (zio#2707)
856b1bd
to
80aefbc
Compare
@guizmaii , I think that the code is ready for review, but I haven't been able to determine why the scala 2.13 async check is timing out. Do you have any suggestions on how to resolve this issue? |
I'm sorry I don't. Maybe @juliano? |
I am not sure, I'm under the impression this is related to the latest scala 2.13 OR to #2633 . I don't have much free time atm, will see if I can find some to have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, it looks good to me! @guizmaii can you please double check?
Thank you @joelsonoda! |
Fixes #2707
Problem
When using onConflictUpdate with the mysql dialect, the values inserted were not being referenced correctly.
Solution
Notes
Not sure if there is a cleaner way to test the same things using query, querySchema and schemaMeta.
Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers