Let SQL Server top statement use parenthesis #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
loicprieur
force-pushed
the
sql_server_runtime_top
branch
from
ce5a06a
to
aacfacf
Compare
loicprieur
force-pushed
the
sql_server_runtime_top
branch
from
aacfacf
to
222e71e
Compare
loicprieur
changed the title
juliano
approved these changes
May 31, 2023
joelsonoda
pushed a commit
to joelsonoda/zio-quill
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2709
Problem
Queries with
.takeagainst SQL Server were failing with:com.microsoft.sqlserver.jdbc.SQLServerException: Incorrect syntax near '@P0'Solution
Wrap the
TOP (parameter)in parenthesis as recommended by MSFT:https://learn.microsoft.com/en-us/sql/t-sql/queries/top-transact-sql?view=sql-server-ver16#compatibility-support
Notes
Additional notes.
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers