Update Dockerfile-setup #2773
Merged
Update Dockerfile-setup #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
reviewed
Jun 13, 2023
| RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ | ||
| ca-certificates \ | ||
| curl \ | ||
| mysql-client \ | ||
| mariadb-client \ |
There was a problem hiding this comment.
Because mysql wasn't available
guizmaii
reviewed
Jun 13, 2023
Comment on lines
-21
to
-24
| # RUN curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - && \ | ||
| # RUN curl https://packages.microsoft.com/config/debian/9/prod.list > /etc/apt/sources.list.d/mssql-release.list && \ | ||
| # RUN apt-get update && \ | ||
| # ACCEPT_EULA=Y apt-get install -y msodbcsql mssql-tools |
There was a problem hiding this comment.
Why did you uncomment these lines? 🤔
There was a problem hiding this comment.
Consistency w/ the other file. If they really shouldn't be there, then why were they there?
There was a problem hiding this comment.
then why were they there?
No idea. That's always the issue with committed commented code 😕
guizmaii
reviewed
Jun 13, 2023
| MAINTAINER gustavo.amigo@gmail.com | ||
|
|
||
| ARG CASSANDRA_URL_BASE=https://archive.apache.org/dist/cassandra/ |
There was a problem hiding this comment.
Why did you change from https://downloads.apache.org/cassandra/ to https://archive.apache.org/dist/cassandra/? 🤔
There was a problem hiding this comment.
Because the requested version wasn't available in downloads.
guizmaii
reviewed
Jun 13, 2023
* Upgrade debian from jessie to bullseye * Switch from mysql-client to mariadb-client * Change from msodbcsql to msodbcsql18 * Replace deprecated apt-key with a trusted.gpg.d entry * Update cassandra url (and use an arg to reduce duplication) * Upgrade cassandra to 3.11.13 * Mostly sync m1 and non-m1 Dockerfile
jsoref
force-pushed
the
build-m1-dockerfile-setup-cassandra-url
branch
from
06b24b5
to
1348998
Compare
joelsonoda
pushed a commit
to joelsonoda/zio-quill
that referenced
this pull request
Jun 27, 2023
* Upgrade debian from jessie to bullseye * Switch from mysql-client to mariadb-client * Change from msodbcsql to msodbcsql18 * Replace deprecated apt-key with a trusted.gpg.d entry * Update cassandra url (and use an arg to reduce duplication) * Upgrade cassandra to 3.11.13 * Mostly sync m1 and non-m1 Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Neither dockerfile works.
Solution
Notes
Additional notes.
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers