Code review of the Ast #2941
Merged
Code review of the Ast #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
commented
Oct 22, 2023
| } | ||
|
|
||
| //************************************************************ | ||
|
|
||
| final class Infix(val parts: List[String], val params: List[Ast], val pure: Boolean, val transparent: Boolean)( | ||
| theQuat: => Quat | ||
| ) extends Ast { | ||
| def quat: Quat = theQuat |
There was a problem hiding this comment.
A few theQuat calls weren't "cached" and were potentially re-computed many times
guizmaii
commented
Oct 22, 2023
| } | ||
|
|
||
| final class Ident private (val name: String)(theQuat: => Quat)(val visibility: Visibility) extends Terminal with Ast { | ||
| private lazy val computedQuat = theQuat |
There was a problem hiding this comment.
We don't need this computedQuat variable. the overrided def quat: Quat method can be just a lazy val
guizmaii
commented
Oct 22, 2023
| @@ -422,7 +425,7 @@ object Visibility extends OpinionValues[Visibility] { | |||
| } | |||
|
|
|||
| sealed trait Renameable extends Opinion[Renameable] { | |||
| def fixedOr[T](plain: T)(otherwise: T) = | |||
| def fixedOr[T](plain: => T)(otherwise: => T): T = | |||
There was a problem hiding this comment.
This wasn't lazy enough. Always computing both sides even if one of them is never used
juliano
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.