Fixes #78: Implement diffing between values which have a common schema #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkharderdev
force-pushed
the
feature/diff
branch
from
93778af
to
ddd0d9e
Compare
jdegoes
reviewed
Jun 15, 2021
|
|
||
| import zio.Chunk | ||
|
|
||
| trait DiffAlgorithm[A] { self => |
There was a problem hiding this comment.
Suggested change
| trait DiffAlgorithm[A] { self => | |
| trait Differ[A] { self => |
jdegoes
reviewed
Jun 17, 2021
thinkharderdev
changed the title
|
Might need a few more unit tests but this is good to go I think now. |
landlockedsurfer
pushed a commit
to landlockedsurfer/zio-schema
that referenced
this pull request
May 28, 2022
…hema (zio#79) * Remove setup gpg * Update setup-java * Test * test2 * test 3 * Fixes zio#78: Implement diffing between instances described by a schema * Specs and additional implementations * Rename DiffAlgorithm to Differ * Add diffs for product and sum types * Copy Myers diff implementation from zio-test * Implement binary diff and unit tests * Fix various temporal diffs and add unit tests * formatting * Test coverage and tweaks * Alphabetical sorting and comments on diff method Co-authored-by: thinkharder <thinkharderdev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP but the design is (mostly) done.
This will implement diffing between values of type
Awhen aSchema[A]is available.