Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes that started using macros to verify
where
,inserts
.group by
etc made possible to get rid ofFeatures.Union[_, _]
and start using intersection types whereverF
composes.So the phantom type
F
of x inval x = name ++ age
will be
Features.Source["name"] with Features.Source["age"]
instead ofFeatures.Union[Features.Source["name"], Features.Source["age"]]
Its possible now to make F contravariant which gives us nice type inference and makes working with dynamic queries nicer. The example of #583 is now possible.
This PR also makes changes to working with nullable columns.
Let's say that
link
describes a nullable column and has a typeOption[String]
.Instead of always having to use
Option("some link")
, users have more possibilities