Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PropagatingSupervisor #681

Merged
merged 2 commits into from
May 6, 2023

Conversation

dmytr
Copy link
Contributor

@dmytr dmytr commented May 6, 2023

Since version 1.25.0 OpenTelemetry JVM agent supports ZIO. There is no need to use PropagatingSupervisor now.

This PR:

  • Removes PropagatingSupervisor.
  • Renames ContextStorage.threadLocal to ContextStorage.openTelemetryContext as it's a much more fitting name.
  • Removes Tracing.propagating because now it's enough to use Tracing.live in combination with ContextStorage.openTelemetryContext.
  • Updates docs section about usage with OpenTelemetry automatic instrumentation.

These are breaking changes, but since we are in RC phase, I hope this is acceptable.

grouzen
grouzen previously approved these changes May 6, 2023
Copy link
Contributor

@grouzen grouzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a significant improvement. Thank you!

@grouzen grouzen merged commit a6ed303 into zio:series/2.x May 6, 2023
20 checks passed
@dmytr dmytr deleted the remove-propagating-supervisor branch May 6, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants