Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC21-1 The fiber's scope has ended before the fiber itself has ended #3910

Closed
Fristi opened this issue Jun 29, 2020 · 9 comments · Fixed by #3912
Closed

RC21-1 The fiber's scope has ended before the fiber itself has ended #3910

Fristi opened this issue Jun 29, 2020 · 9 comments · Fixed by #3912
Labels
bug Something isn't working

Comments

@Fristi
Copy link
Contributor

Fristi commented Jun 29, 2020

Since upgrading to RC21-1 we'll get:

java.lang.IllegalStateException: Defect: The fiber's scope has ended before the fiber itself has ended

Anyone else? We are using interop-cats, http4s, doobie.

Working on a reproduction case

@sebver
Copy link

sebver commented Jun 29, 2020

This is a reproduction with http4s: https://github.com/sebver/zio-http4s-scope-issue

There are some instructions in the readme, you should see the error appear after a wile.

The requests don't actually fail - so I'm not sure what the consequences are.

@adamgfraser
Copy link
Contributor

Thanks for reporting! Will take a look.

@adamgfraser adamgfraser added the bug Something isn't working label Jun 29, 2020
@adamgfraser
Copy link
Contributor

Looks like this issue also replicates on RC21. Can you confirm?

@sebver
Copy link

sebver commented Jun 29, 2020

I just checked and I can confirm. We hadn't noticed since we upgraded straight to RC21-1 from RC20.

@adamgfraser
Copy link
Contributor

Makes sense, it just helps narrow down the cause since it eliminates one potential change that was made in RC21-1 as a candidate.

@adamgfraser
Copy link
Contributor

@Fristi @sebver We just merged #3910 which should fix this. If you have a chance and are able to test with snapshots could you let me know if this resolves your issue?

@sebver
Copy link

sebver commented Jun 30, 2020

@adamgfraser I just let it run locally for a while and it appears to be fixed! 🙏

Just checking if there are any plans for an RC21-2 at some point? Don't mind verifying it in our test/production environments, but a snapshot is a bit of a hard sell there. 😄

@adamgfraser
Copy link
Contributor

@sebver Totally makes sense! 😃

Yes, I think so, maybe after #3883 and #3919 get merged.

@Fristi
Copy link
Contributor Author

Fristi commented Jul 1, 2020

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants