-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests over to 'shared' so they run on Scala.js #804
Comments
|
Not every test requires |
Is anyone actively working on this one? If not I would give it or a part of it a go late next week. |
@vilu this issue can be split to many small PRs. |
I take two easy ones for the start: |
If anybody is interested in |
Today I migrate |
My idea for some other tests is to replace |
We can't block for result in scala-js, scalacheck is 100% synchronous on the other hand. |
I was looking into PlatformSpec, should this one be really be considered in this ticket seeing how the implementation differs between js/jvm? Maybe just removing this one from the list would make sense? |
#804 - Move promise spec from core-jvm to core-shared
A bunch of test suites right now run only on the JVM. As many as possible should be migrated over to
shared
so they run in Scala.js configuration.The tests are currently located in
core/jvm/src/test/scala/scalaz/zio
and could be moved (one by one, PR by PR) tocore/shared/src/test/scala/scalaz/zio
.Some of these may reveal bugs in Scala.js support that can then be fixed separately.
If anyone has interest in giving a hand here, just reply to this thread and pick out one of the test suites to migrate over (some will be quite simple).
The text was updated successfully, but these errors were encountered: