Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning Zio-QuickStarts in Overview Guides Results in Fatal if User has Incorrect Rights #8782

Closed
Yummy-Yums opened this issue Apr 22, 2024 · 6 comments
Labels
documentation Documentation improvements

Comments

@Yummy-Yums
Copy link
Contributor

Yummy-Yums commented Apr 22, 2024

Hello , the link in quickstart guide for restfule web service uses ssh login. it'll be easier to just clone via Https ? Thanks

image

@khajavi
Copy link
Member

khajavi commented Apr 24, 2024

@Yummy-Yums Right! Are you interested in creating a pull request to fix the issue?

@khajavi khajavi added the documentation Documentation improvements label Apr 24, 2024
@Yummy-Yums
Copy link
Contributor Author

Yummy-Yums commented Apr 24, 2024 via email

@Yummy-Yums
Copy link
Contributor Author

Yummy-Yums commented Apr 26, 2024

@khajavi I realized zio-quickstarts exists as a separate repo and is also contained in the main zio repo. do i change both? or main repo is enough. Also, cloning via SSH is a common occurrence across the docs so i'd have to update that as well

@khajavi
Copy link
Member

khajavi commented Apr 26, 2024

@Yummy-Yums We should update both.

@Yummy-Yums
Copy link
Contributor Author

Yummy-Yums commented Apr 26, 2024

@Yummy-Yums We should update both.

@khajavi Secondly , i noticed some cli commands are wrapped in scala , is it not supposed to be bash like below, is there a reason for this?

image

@khajavi
Copy link
Member

khajavi commented Apr 26, 2024

@Yummy-Yums They are the mistake! Need to be fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements
Projects
None yet
Development

No branches or pull requests

2 participants