Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release zio for scala 2.13 #1104

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Release zio for scala 2.13 #1104

merged 5 commits into from
Jul 10, 2019

Conversation

mijicd
Copy link
Member

@mijicd mijicd commented Jun 29, 2019 •
edited

Closes #1007.

@mijicd mijicd added the WIP Work in progress label Jun 29, 2019
@neko-kai
Copy link
Member

YES

@henricook
Copy link

Pleeeeeeeeeeeeeease

@jdegoes
Copy link
Member

jdegoes commented Jun 30, 2019

There's a few 2.13 failures, around collections in STM, looks like. Super excited to get this through though, let me know if I can help!

@mijicd
Copy link
Member Author

mijicd commented Jun 30, 2019 via email

@softinio softinio mentioned this pull request Jun 30, 2019
Merged
@neko-kai neko-kai mentioned this pull request Jul 9, 2019
Merged
@neko-kai
Copy link
Member

neko-kai commented Jul 9, 2019

@mijicd
Do you have the cycles currently to finalize the PR? I've checked how much is left and it seems with a few fixes it's ready to ship.
I've opened a PR to your fork: mijicd#1 (I've decided to @silence collection-related warnings instead of using scala-collection-compat, since deprecated methods won't be removed during the 2.13 cycle anyway.)

@mijicd
Copy link
Member Author

mijicd commented Jul 10, 2019

@Kaishh I've planned to wrap it up today, as I've finally found some spare time. Thanks for helping, merged your PR. Regarding scala-collection-compat, it would collide with no dependency policy, and it doesn't really solve all the issues, so this might be an acceptable approach.

mijicd and others added 5 commits July 10, 2019 13:38
@mijicd
Update build config
b9e5550
@mijicd
Remove compiler options not existing in 2.13
68b58ba
@mijicd
Fix unapplied methods
29172e7
@mijicd
Avoid implicit conversion to indexed seq
910c379
@neko-kai @mijicd
Finalize 2.13 build:
6e1ee3a 
* inline `linesIterator` implementation to avoid calling either lines or linesIterator deprecated methods
* silence JavaConverters and Queue.enqueue warnings, since they won't be removed during 2.13 cycle
* disable benchmarks and mdoc for 2.13, since mdoc & benchmark dependencies are not available yet
@mijicd mijicd removed the WIP Work in progress label Jul 10, 2019
@mijicd mijicd requested a review from a team July 10, 2019 14:11
@mijicd
Copy link
Member Author

mijicd commented Jul 10, 2019

This one's ready to be reviewed. After a discussion with @Kaishh, we agreed to move out the custom Queue implementation and tackle it separately.

iravid
iravid approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@jdegoes jdegoes merged commit b81c690 into zio:master Jul 10, 2019
@jdegoes
Copy link
Member

jdegoes commented Jul 10, 2019

@Kaishh Great idea!

@mijicd Thanks for your work on this!

giphy

@mijicd mijicd deleted the 2.13 branch August 14, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

@iravid iravid iravid approved these changes

@neko-kai neko-kai neko-kai approved these changes

@softinio softinio softinio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build for 2.13.0
6 participants
@mijicd @neko-kai @henricook @jdegoes @iravid @softinio