Introduce real companion object for Sink (#1111) #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
geymed
added a commit
to geymed/interop-reactive-streams
that referenced
this pull request
Jul 7, 2019
This will hopefully help to fix failing docs compilation in this PR: zio/zio#1144
geymed
added a commit
to geymed/interop-reactive-streams
that referenced
this pull request
Jul 7, 2019
This will hopefully help to fix failing docs compilation in this PR: zio/zio#1144 Since Sink val (which refer to `ZSink`) in package object will now be replaced by a real companinon object it will loose some ZSink methods. It seems that the intention here was to import ZSink
neko-kai
pushed a commit
to zio/interop-reactive-streams
that referenced
this pull request
Jul 8, 2019
This will hopefully help to fix failing docs compilation in this PR: zio/zio#1144 Since Sink val (which refer to `ZSink`) in package object will now be replaced by a real companinon object it will loose some ZSink methods. It seems that the intention here was to import ZSink
|
This is failing #1147 disables typechecking on that doc for now until we update interop-reactive-streams, so we can ignore that failure. |
iravid
previously approved these changes
Jul 8, 2019
geymed
force-pushed
the
sink-companion-object
branch
from
b14adb8
to
fb3362a
Compare
|
@iravid thanks for reviewing this. Looks like all checks are passing now. |
iravid
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1111 (for Sink)