Deprecate succeedLazy

[ioleo]

Fixes #1346

• Deprecated all succeedLazy methods.
• Delegated all deprecated methods to succeed.
• Added missing succeed to ZSink, Sink and ZStreamChunk.
• Removed succeedLazy test from RTSSpec
• Replaced succeedLazy with effect or effectTotal where laziness was essential and with succeed where lazyness was not required
• Updated docs

[ioleo]

@shankarshastri Fixed docs.

[neko-kai]

Delegated all deprecated methods to succeed.

I think we should delegate to effectTotal to not break existing usages and since effectTotal is now the only blessed way to delay evaluation.

[neko-kai]

Thank you for the hard work! 🙏 Some comments, and I do think the deprecated methods should redirect to effectTotal (or possibly stay unmodified) to not break callers on upgrade.

[vasilmkd]

What is the impact of this on ZStream, given that ZManaged.succeedLazy is used to implement effectful folding? /cc @iravid

[iravid]

ZManaged.succeedLazy(a) is just ZManaged.fromEffect(ZIO.effectTotal(a)) so we can name that ZManaged.effectTotal. Can be done in a separate PR as other data types have a succeedLazy too.

[ioleo]

@Kaishh
There is no effectTotal on Fiber, STM, Schedule, ZSchedule, Sink, ZSink, StreamPure, ZStream and ZStreamChunk. For all others I've switched to effectTotal as you sugested. For Managed / ZManaged I introduced effectTotal as @iravid suggested.

[jdegoes]

@ioleo Excellent work, thank you for this! 🙏