Add ZSink.splitLines #1384
Add ZSink.splitLines #1384
Conversation
iravid
force-pushed
the
sink-splitlines
branch
from
cea6b87
to
e906d76
Compare
|
Oh this has a bug when |
iravid
force-pushed
the
sink-splitlines
branch
from
e906d76
to
8de3602
Compare
|
All done. @vasilmkd could you have a look? |
|
It'll be my pleasure. I'll review it first thing in the morning. |
| /** | ||
| * Splits strings on newlines. Handles both `\r\n` and `\n`. | ||
| */ | ||
| final val splitLines: ZSink[Any, Nothing, String, String, Chunk[String]] = |
There was a problem hiding this comment.
Not to nitpick here, but I see this as a deviation from the previous sinks, which have all been defined with def. AFAIK val creates objects eagerly, and they stay in memory for the duration of the program which references this code. Is that something desirable in this case? I may be completely off base here, I just want to hear the reasoning. Same for every other val, including the ones in Sink.
| */ | ||
| final val splitLines: ZSink[Any, Nothing, String, String, Chunk[String]] = | ||
| new SinkPure[Nothing, String, String, Chunk[String]] { | ||
| type State = (Chunk[String], Option[String], Boolean) |
There was a problem hiding this comment.
On an urelated note, this is probably what the stepless sinks' code will look like after the refactoring. :)
Or a predicate function. |
|
This needs a rebase and should be good for merging. |
iravid
force-pushed
the
sink-splitlines
branch
2 times, most recently
from
52a3859
to
a7f7153
Compare
iravid
force-pushed
the
sink-splitlines
branch
from
a7f7153
to
bc4a90b
Compare
No description provided.