Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIO Test: Rename Predicate and Assertion #1500

Merged
merged 1 commit into from Aug 27, 2019
Merged

Conversation

adamgfraser
Copy link
Contributor

It feels like #1438 is getting a little unwieldy so trying to break it up a bit. This resolves #1475 and changes Assertion to AssertResult and Predicate to Assertion along with various conforming changes.

The only thing I did not do is change FailureDetails to TestFailure since my understanding is that will stick around in the future in a slightly modified form as:

final case class FailureDetails(fragment: PredicateValue, whole: PredicateValue)
// to be refactored to be a nonempty list

sealed trait TestFailure[+E]
object TestFailure {
  final case class Assertion(result: AssertResult[FailureDetails]) extends TestFailure[Nothing]
  final case class Runtime[+E](cause: Cause[E]) extends TestFailure[E]
}

Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to break this up, & looks good to me!

@jdegoes jdegoes merged commit 4a0c4ab into zio:master Aug 27, 2019
@adamgfraser adamgfraser deleted the 1475 branch August 27, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZIO Test: Minor renames to prepare for initial release
3 participants