New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ZSchedule to Schedule #2242
Conversation
You are fast :D |
Can I ask why the renaming? The Z prefix is kind of a theme to indicate that this is the most powerful version of a type, usually with the |
@regiskuckaertz I think the idea is that to use the "Z" nomenclature there should be sufficient use of the "non-Z" variant. So like for |
Gotcha. I think we should take a look at all the data structures perhaps to be consistent? I’m always flummoxed by the missing |
That's a great point. I think the principle should be that all types have corresponding objects and that the object should include all combinators that make sense for the constraints on the |
@regiskuckaertz 💯 That needs cleaning up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, the only thing I might do is add a ZSchedule
type alias in the package object that is deprecated for 1.0.
All set. |
* rename ZSchedule to Schedule * add type alias
Resolves #2054.