Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ZManaged#flattenM #3464

Merged
merged 3 commits into from Apr 26, 2020
Merged

Implement ZManaged#flattenM #3464

merged 3 commits into from Apr 26, 2020

Conversation

adamgfraser
Copy link
Contributor

Like unwrap but when the ZIO is on the inside instead of the outside.

@adamgfraser adamgfraser requested a review from iravid April 26, 2020 16:17
@iravid iravid merged commit 3b98b11 into zio:master Apr 26, 2020
wi101 pushed a commit to wi101/scalaz-zio that referenced this pull request Apr 29, 2020
Add test for Schedule#onDecision and documentation for scheduling (zio#3346)

* Add test for Schedule#onDecision and documentation for scheduling

* Add documentation to datatypes, remove console functions from ScheduleSpec

* fix mdoc compile issue

specialize ChunkBuilder (zio#3400)

Implement ZRefM (zio#3391)

* implement ZRefM

* fix Scala 2.13 compatibility issue

* address review comments

* implement SubscriptionRef

* make constructor private

* remove managed variant

* remove unused import

Implement ZIO#mapEffect (zio#3404)

* implement mapEffect

* implement mapPartial

Improve TArray's performance (zio#3407)

* Benchmark TArray

* Implement fold and transform via unsafe

* Improve readability

* Implement find via unsafe

* Implement findLast via unsafe

* Implement foldM via unsafe

* Benchmark indexWhere

* Implement transformM via unsafe

* Implement indexWhere via unsafe

* Implement lastIndexOf via unsafe

* Remove duplicated code

* Implement foldM via ZIO.foldLeft

* Remove 0-sized array from benchmark

* Implement reduceOption via unsafe

* Implement findM via foldM

* Help inference via Option.empty

* Implement findM via iterate

* Implement findLastM via iterate

* Remove useless val

* Format the sources

Update sbt-header to 5.6.0 (zio#3411)

Add AssertionM for effectfull assertions (zio#3403)

Add result field to AssertionValue to avoid test reevaluation.
Protect AssertionValue.assertion to avoid test reevaluation.

Use lazy val tryValue = Try(value) to avoid exception reevaluation:
lazy val stores only successful case.

implement launch (zio#3415)

Add alternative combinator to ZSTM (zio#3414)

* Drop duplicated test

* Remove unnecessary .unit calls

* Align the naming

* Write failing tests

* Keep semantically correct orElse tests

* Fix test expectations

* Fix orElse behavior on failures

* Fix orElse behavior on retries

* Reduce flakiness

* Revert orElse changes

* Introduce alternative combinator

* Update docs

* Reduce flakiness

* Make right retry explicit

* Race updater and transaction

* Move left-right recovery test to JVM tests

* Drop E from orElseSucceed

Co-Authored-By: John A. De Goes <john@degoes.net>

* Rename alternative to orTry

Co-Authored-By: John A. De Goes <john@degoes.net>

* Revert "Move left-right recovery test to JVM tests"

This reverts commit 19f1162.

* Tag retry test as JVM-only

* Fix compilation issues

* Fix docs

* Improve scaladoc

Co-Authored-By: John A. De Goes <john@degoes.net>

* Fix doc mistake

Co-authored-by: John A. De Goes <john@degoes.net>

Update sbt-scalafix to 0.9.15 (zio#3423)

Optimize TQueue (zio#3421)

Update sbt-ci-release to 1.5.3 (zio#3425)

ZIO Test: Support Laws for Capabilities Parameterized on Two Types (zio#3420)

* implement ZLaws2

* use AnyF

Back up Chunk[Boolean] by Chunk.BitChunks (zio#3419)

fix publishing (zio#3433)

WIP: Scala.js upgrade to v1.0.0 (zio#2392) (zio#2479)

* Update to Scala.js 1.0.0-RC2

* fix for passing testJS

* formatting fix

* Merge remote-tracking branch 'upstream/master' into feature/scalajs-1.0.0-RC2

* Merge branch 'master' of https://github.com/zio/zio into feature/scalajs-1.0.0-RC2

* sonatype resolver added for izumi-reflect;
magnolia updated to v0.12.8

Fix Scala.js build (post zio#2479) (zio#3436)

* Fix Scala.js build (post zio#2479)

* Move back to shared/Executor source and add jvm/js/native ExecutorPlatformSpecific trait

* Fix imports causing build failure on 2.13/dotty

Update Magnolia (zio#3432)

* Update Magnolia

There is a bug in Magnolia versions < 0.15 which causes derivation for case classes with default values to fail.
The update should fix it.

* Add scala-reflect % Provided dependency, now required for magnolia & exclude scala-compiler

Co-authored-by: Kai <450507+neko-kai@users.noreply.github.com>
Co-authored-by: Kai <kai@7mind.io>

Update nyaya-gen to 0.9.1 (zio#3438)

Remove sonatype public resolver (zio#3434)

Add specialized accessor operations to Chunk (zio#3431)

* Add specialized accessor operations to Chunk

* Generate only non-empty chunks using chunkWithIndex generator

Add ZIO STM blogpost (zio#3443)

generalize (zio#3439)

Update scala-java-time to 2.0.0 (zio#3446)

suspend effects (zio#3444)

Fix Publishing on Master (zio#3437)

* fix publishing

* fix bug

add Scalac logo to the Sponsors section in Readme (zio#3379)

Implement ZIO#service (zio#3422)

* implement getService

* add variants

* rename

Add Diagnostic Code to Has (zio#3377)

* add diagnostic code

* Fix environment composition

* Fix 2.11/dotty

Co-authored-by: ioleo <ioleo+git@protonmail.com>

Use short forms where it makes sense (zio#3452)

* Use short forms where it makes sense

* One more `none` usage.

Update to izumi-reflect 1.0.0-M1, use izumi-reflect on dotty (zio#3445)

* Update to izumi-reflect-1.0.0-M1, depend on izumi-reflect in dotty

* Use one VersionSpecific file for dotty & scala-2

* Adding type signatures to Mock modules to workaround scala/scala3#8764

error:

```
  [error] -- Error: PureModule.scala:77:86
  [error] 77 |  val static                                           = ZIO.accessM[PureModule](_.get.static)
  [error]    |                                                                                      ^
  [error]    |could not find implicit value for izumi.reflect.Tag[zio.test.mock.module.PureModule.Service]. Did you forget to put on a Tag, TagK or TagKK context bound on one of the parameters in zio.test.mock.module.PureModule.Service? e.g. def x[T: Tag, F[_]: TagK] = ....
  [error]    |I found:
  [error]    |
  [error]    |    {
  [error]    |      izumi.reflect.Tag.apply[zio.test.mock.module.PureModule.Service](classOf[Any]
  [error]    |        ,
  [error]    |      {
  [error]    |        <empty> :izumi.reflect.macrortti.LightTypeTag
  [error]    |      }
  [error]    |      ):izumi.reflect.Tag[zio.test.mock.module.PureModule.Service]
  [error]    |    }
  [error]    |
  [error]    |But method tagFromTagMacro in object Tag does not match type izumi.reflect.Tag[zio.test.mock.module.PureModule.Service].
  [error]    |
  [error]    |The following import might make progress towards fixing the problem:
  [error]    |
  [error]    |  import izumi.reflect.Tag.tagFromTagMacro
```

* add type signature to SpecSpec to workaround error:

```
[error] -- Error: SpecSpec.scala:17:51
[error] 17 |  val layer = ZLayer.succeed(new Module.Service {})
[error]    |                                                   ^
[error]    |could not find implicit value for izumi.reflect.Tag[zio.test.SpecSpec.Module.Service]. Did you forget to put on a Tag, TagK or TagKK context bound on one of the parameters in zio.test.SpecSpec.Module.Service? e.g. def x[T: Tag, F[_]: TagK] = ....
[error]    |I found:
[error]    |
[error]    |    {
[error]    |      izumi.reflect.Tag.apply[zio.test.SpecSpec.Module.Service](classOf[Any],
[error]    |        {
[error]    |          <empty> :izumi.reflect.macrortti.LightTypeTag
[error]    |        }
[error]    |      ):izumi.reflect.Tag[zio.test.SpecSpec.Module.Service]
[error]    |    }
[error]    |
[error]    |But method tagFromTagMacro in object Tag does not match type izumi.reflect.Tag[zio.test.SpecSpec.Module.Service].
[error]    |
[error]    |The following import might make progress towards fixing the problem:
[error]    |
[error]    |  import izumi.reflect.Tag.tagFromTagMacro
```

* Lift `exceptDotty` from HasSpec & ComposedMockSpec (TaggedSpec still won't pass because deriving is not implemented)

* add type signatures to MockSpecUtils, update comments

* Workaround type inference-caused test failures in PolyMockSpec - Any was inferred for `Tag` now, probably maybe because Tag parameter is AnyKind, add workaround

* Fix `@mockable` macro, restrict valid `Tagged` definitions to just izumi.reflect.Tag

* sbt fix

fix type signature (zio#3455)

Update util-core to 20.4.1 (zio#3457)

generalize type signature (zio#3460)

doc(test_effects) : add aspect ignore (zio#3462)

upgrade monix version (zio#3467)

Implement ZManaged#flattenM (zio#3464)

* implement flattenM

* format

* fix Scaladoc

reorder type parameters (zio#3463)

Implement ZManaged#release (zio#3466)

* implement ZManaged#release

* rename

Use ChunkBuilder more prominently in Chunk (zio#3453)

* make Chunk use ChunkBuilder

* fix lint failure

* consistent parenthesis use

* use parens for Chunkbuilder#make

* followup

* retrigger ci

Update reactor-core to 3.3.5.RELEASE (zio#3472)

Update magnolia to 0.16.0 (zio#3473)

Update nyaya-gen to 0.9.2 (zio#3474)

added blog to list (zio#3471)

* updated blog for RC18 + http4s .21.x

* added new blog to resource page

Co-authored-by: Pierre Ricadat <ghostdogpr@users.noreply.github.com>

Add zio-easymock to libraries with zio support list (zio#3481)

Add ZIO#filterNot and ZSTM#filterNot (zio#3477)

* Add ZIO#filterNot and ZSTM#filterNot

* Fix typos

implement assertElements and assertElements
@adamgfraser adamgfraser deleted the flattenm branch April 29, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants